Skip to content

Feature/fix fullinfo error code#266

Open
zeyus wants to merge 1 commit intosccn:devfrom
NexusDynamic:feature/fix-fullinfo-error-code
Open

Feature/fix fullinfo error code#266
zeyus wants to merge 1 commit intosccn:devfrom
NexusDynamic:feature/fix-fullinfo-error-code

Conversation

@zeyus
Copy link
Contributor

@zeyus zeyus commented Mar 2, 2026

There is an issue with getting a stream fullinfo.

Because EC is not initialized with lsl_no_error the value of ec can be undefined, resulting in checks of ec incorrectly reporting that there was an error ec != 0.

This just adds the same initialization that exists in other functions that use ec

@zeyus
Copy link
Contributor Author

zeyus commented Mar 2, 2026

not sure what happened with the formatting (and teh extra commit that snuck in there!)...I'll fix it later today.

Edit: and done!

@zeyus zeyus force-pushed the feature/fix-fullinfo-error-code branch from 7eb0a08 to 6b46594 Compare March 2, 2026 13:07
.idea/
/cmake-build-*/
/examples/build*/
.vscode/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to avoid checking in IDE-related config.
This directory was created locally because I usually have auto-format on, but I have disabled it for liblsl because it made the commits change a bunch of lines in every file I touched with the c++ formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant