Skip to content

Bump Snakeyaml to 2.3 #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Bump Snakeyaml to 2.3 #618

merged 4 commits into from
Feb 18, 2025

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Feb 17, 2025

No description provided.

@smlpt smlpt added the dependencies Pull requests that update a dependency file label Feb 17, 2025
@smlpt smlpt requested a review from kephale February 17, 2025 09:05
@ctrueden
Copy link
Member

Since sciview doesn't actually use snakeyaml directly, the right thing to do is to remove the dependency altogether. But also: we should upgrade pom-scijava to 40.0.0, so that we inherit the component such as ui-behaviour at versions depending on snakeyaml 2.x. I'm working on it.

Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on addressing this by upgrading sciview to pom-scijava 40.0.0, and removing the snakeyaml dep altogether.

The snakeyaml project is not actually used by sciview directly.
We want to let it come in transitively for use by dependencies.
This eliminates the SLF4J warnings relating to:
> Class path contains SLF4J bindings targeting
> slf4j-api versions 1.7.x or earlier

See https://www.slf4j.org/codes.html#ignoredBindings for details.

(The hardcoded version will only be necessary until pom-scijava
upgrades from 1.7.36 to 2.x.)
Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM now on my side. @kephale What do you think?

@ctrueden ctrueden merged commit 26738f7 into main Feb 18, 2025
3 checks passed
@ctrueden ctrueden deleted the snakeyaml-2.3 branch February 18, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants