Upgrade to Blacklight 9 #3177
Merged
Upgrade to Blacklight 9 #3177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't even use whatever blacklight email/sms functionality these are about. projectblacklight/blacklight@28a112e
…ages for collections
… BL9, in collection and featured topic index Partial removed at: projectblacklight/blacklight@b0f550b Modelled for correct usage on https://github.com/projectblacklight/blacklight/blob/2e58b9e77e7d0dc129aa4d9421d3faadb1187068/app/views/catalog/_search_results.html.erb
…featured topic index pages based on https://github.com/projectblacklight/blacklight/blob/2e58b9e77e7d0dc129aa4d9421d3faadb1187068/app/views/catalog/_search_results.html.erb But not using i18n, it wasn't doing what we wanted or doing anything useful
…cordion New direction of arrow/caret icons are preferred by Nielsen, we'll stick with them: https://www.nngroup.com/articles/accordion-icons/
Oddly, it seems `params:` arg IS intended to allow a Blacklight::SearchBuilder value, it's in the yard docs. Avoids this deprecation warning: > DEPRECATION WARNING: Passing positional arguments to search() is deprecated. Use the params kwarg instead. (called from FeaturedTopicController#total_count at /Users/jrochkind/code/scihist_digicoll/app/controllers/featured_topic_controller.rb:44
….0.beta8 This seems to be what it requires of us. Under discussion in projectblacklight/blacklight#3762 it is somewhat possible it will change before 9.0.0 final, although some people strongly prefer it this way.
eddierubeiz
approved these changes
Nov 10, 2025
…h_builder Refactor SearchBuilder search logic customizations for Blacklight 9.0.0.beta8
Contributor
Author
|
Oh forgot to mention, one (the only?) user-visible change by BL9 upgrade is our facet sidebar expand/contract icons change, as BL changed them. Googling reveals Nielsen Group user researchers endorse the new BL9 icons as the ones generally most recognized by users for facet expand/contract, so we went with it. https://www.nngroup.com/articles/accordion-icons/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make #2479 and #3062 easier
Also will need to include something for SearchBuilder BL9 refactor if that goes forward. projectblacklight/blacklight#3762