Refactor SearchBuilder search logic customizations for Blacklight 9.0.0.beta8 #3182
Conversation
jrochkind
force-pushed
the
refactor_for_facet_search_builder
branch
from
653f947 to
379b8ff
Compare
|
oops this is green locally, have to figure out if I forgot to commit something or what. |
….0.beta8 This seems to be what it requires of us. Under discussion in projectblacklight/blacklight#3762 it is somewhat possible it will change before 9.0.0 final, although some people strongly prefer it this way.
jrochkind
force-pushed
the
refactor_for_facet_search_builder
branch
from
379b8ff to
0866ffa
Compare
|
oh right, I forgot to add 3 of the 6-7 new classes required. |
|
Note that with further changes jcoyne is suggesting at https://github.com/projectblacklight/blacklight_range_limit/pulls , it would be an additional one search builder file per catalog controller (so 3 more for our current setup). Every controller you add with different default serach behavior would require another 3-4 files per controller. If you add another plugin similar to blacklight range limit, it would add another file per controller. We don't love this. For now, we will merge this PR though, to move ahead with BL 9.beta4 per our plans -- if things change, it is hopefully fairly easy to undo this refactor. |
This seems to be what it requires of us. Under discussion in projectblacklight/blacklight#3762 it is somewhat possible it will change before 9.0.0 final, although some people strongly prefer it this way.