⬆️ Update submodule #263
Merged
⬆️ Update submodule #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will update the submodule to mainly bring in the ruby-saml patch.
ShanaLMoore
reviewed
Sep 11, 2024
Gemfile.lock
Outdated
| @@ -1242,7 +1242,7 @@ GEM | |||
| multipart-post | |||
| oauth2 | |||
| ruby-progressbar (1.13.0) | |||
| ruby-saml (1.16.0) | |||
| ruby-saml (1.17.0) | |||
There was a problem hiding this comment.
Gemfile.lock shouldn't exist in the knapsack, according to Rob
There was a problem hiding this comment.
alright sounds good i can delete the whole thing then
Gemfile.lock files should not exist for knapsack projects apparently so I am removing this.
When running tests locally, a Gemfile.lock will generate, but we don't want to commit it so ignoring it gets it out of the way.
|
@kirkkwang can this be closed? |
Not yet, I need an approval and it has to get merged. |
aprilrieger
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will update the submodule to mainly bring in the ruby-saml patch.