Revert change and ignore rubocop #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
suggested changes
Aug 4, 2023
| hash = super(input_hash, presenter: presenter, solr_doc_hits: solr_doc_hits) | ||
| # rubocop:disable Lint/ShadowedArgument | ||
| def sanitize_v3(hash:, presenter:, solr_doc_hits:) | ||
| hash = super |
There was a problem hiding this comment.
I think this is not going to work. The method signature of sanitize_v3 is all key words, when you pass that to super it's going to be a method error. Also, the shadow argument is something to consider and work to avoid, as it can become confusing what variable you're meaning.
There was a problem hiding this comment.
I read the IIIF Print definition/signature of sanitize_v3; it is def sanitize_v3(hash:, presenter:, solr_doc_hits:). So my point about parameters for super is mute.
However, I would like to consider renaming the local variable of hash to something other than hash (as that is the parameter name). What about returning_hash?
jeremyf
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.