-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i852 New worker to run resource intensive jobs #969
Merged
bkiahstroud
merged 21 commits into
main
from
i852-new-worker-to-run-resource-intensive-jobs
Feb 14, 2024
Merged
i852 New worker to run resource intensive jobs #969
bkiahstroud
merged 21 commits into
main
from
i852-new-worker-to-run-resource-intensive-jobs
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rob Kaufman <[email protected]>
Change pulled from: - samvera/hyku#2145
Because of the special way `extraDeploy` gets interpreted, fetching ENV values using `$` will not work.
We will be reusing this pattern across several projects. Not every extra worker will need increased resource limits, so we should use a more generic name that can apply to various requirements.
Sidekiq queues without explicit weights are prioritized in the order they are listed. Our auxiliary worker's primary goal is to process jobs in the auxiliary queue, thus we want it to be the top priority. [Sidekiq docs](https://github.com/sidekiq/sidekiq/wiki/Advanced-Options#queues)
2 tasks
orangewolf
approved these changes
Feb 13, 2024
bkiahstroud
deleted the
i852-new-worker-to-run-resource-intensive-jobs
branch
February 14, 2024 01:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs
Adds an extra worker to both local development and actively used r2 deployments that runs a new Sidekiq queue called
:auxiliary
.This new worker ("auxiliary worker") has higher resource limits in r2. This is so that we can run
CreateLargeDerivativeJobs
(i.e.ffmpeg
for videos and audio files) without bogging down the default worker (see #955 for more details).Notes
Similar PR in Adventist: