use templates and config maps to get the settings for sidekiq the way we want #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkiahstroud
requested changes
Feb 26, 2024
| extraEnvVars: *envVars | ||
| extraEnvFrom: | ||
| - configMapRef: | ||
| name: auxilary-worker-env |
There was a problem hiding this comment.
I hadn't put this back into pals yet, but in adventist we established this pattern:
- Use "aux" instead of "auxiliary"
- Put "worker" before "aux"
Suggested change
| name: auxilary-worker-env | |
| name: worker-aux-env |
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: auxiliary-worker-env |
There was a problem hiding this comment.
Suggested change
| name: auxiliary-worker-env | |
| name: worker-aux-env |
| extraEnvVars: *envVars | ||
| extraEnvFrom: | ||
| - configMapRef: | ||
| name: auxilary-worker-env |
There was a problem hiding this comment.
Suggested change
| name: auxilary-worker-env | |
| name: worker-aux-env |
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: auxiliary-worker-env |
There was a problem hiding this comment.
Suggested change
| name: auxiliary-worker-env | |
| name: worker-aux-env |
| @@ -4,13 +4,9 @@ if ENV['GOOGLE_OAUTH_PRIVATE_KEY_VALUE'] && !ENV['GOOGLE_OAUTH_PRIVATE_KEY_VALUE | |||
| end | |||
|
|
|||
| if ENV['DATABASE_URL'] && !ENV['DATABASE_URL'].empty? | |||
| ENV['DATABASE_URL'] = ENV['DATABASE_URL'].gsub('pool=5', 'pool=30') | |||
| ENV['DATABASE_URL'] = ENV['DATABASE_URL'].gsub('pool=5', "pools=#{ENV.fetch('WORKER_CONCURENCY'), 30}") | |||
There was a problem hiding this comment.
Typo
Suggested change
| ENV['DATABASE_URL'] = ENV['DATABASE_URL'].gsub('pool=5', "pools=#{ENV.fetch('WORKER_CONCURENCY'), 30}") | |
| ENV['DATABASE_URL'] = ENV['DATABASE_URL'].gsub('pool=5', "pools=#{ENV.fetch('WORKER_CONCURRENCY'), 30}") |
| else | ||
| exec "echo $DATABASE_URL && bundle exec sidekiq" | ||
| end | ||
| exec "echo $DATABASE_URL && RAILS_MAX_THREADS=$WORKER_CONCURENCY bundle exec sidekiq $WORKER_ARGS" |
There was a problem hiding this comment.
Suggested change
| exec "echo $DATABASE_URL && RAILS_MAX_THREADS=$WORKER_CONCURENCY bundle exec sidekiq $WORKER_ARGS" | |
| exec "echo $DATABASE_URL && RAILS_MAX_THREADS=$WORKER_CONCURRENCY bundle exec sidekiq $WORKER_ARGS" |
| labels: | ||
| {{- include "hyrax.labels" . | nindent 4 }} | ||
| data: | ||
| WORKER_CONCURENCY: "5" |
There was a problem hiding this comment.
Suggested change
| WORKER_CONCURENCY: "5" | |
| WORKER_CONCURRENCY: "5" |
| labels: | ||
| {{- include "hyrax.labels" . | nindent 4 }} | ||
| data: | ||
| WORKER_CONCURENCY: "1" |
There was a problem hiding this comment.
Suggested change
| WORKER_CONCURENCY: "1" | |
| WORKER_CONCURRENCY: "1" |
| labels: | ||
| {{- include "hyrax.labels" . | nindent 4 }} | ||
| data: | ||
| WORKER_CONCURENCY: "5" |
There was a problem hiding this comment.
Suggested change
| WORKER_CONCURENCY: "5" | |
| WORKER_CONCURRENCY: "5" |
| labels: | ||
| {{- include "hyrax.labels" . | nindent 4 }} | ||
| data: | ||
| WORKER_CONCURENCY: "1" |
There was a problem hiding this comment.
Suggested change
| WORKER_CONCURENCY: "1" | |
| WORKER_CONCURRENCY: "1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply an alternative approach to the existing way of getting the aux worker configured properly. Trying to find the best pattern.