🐛 Fix cropped banner images being overwritten #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cropper.js intercepts an updated banner image file and crops it, the original filename gets changed to cropped.jpg which gets saved to disk. When another tenant crops their banner image, it also gets saved as cropped.jpg and overwrites the previous tenant's banner image. In this commit, we prepend the tenant name so it would look something like `shared-cropped.jpg` and `uindy-cropped.jpg` instead and avoids the files from being overwritten. Ref: - #948 - #746
ShanaLMoore
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cropper.js intercepts an updated banner image file and crops it, the original filename gets changed to cropped.jpg which gets saved to disk. When another tenant crops their banner image, it also gets saved as cropped.jpg and overwrites the previous tenant's banner image. In this commit, we prepend the tenant name so it would look something like
shared-cropped.jpganduindy-cropped.jpginstead and avoids the files from being overwritten.Ref:
Expected Behavior Before Changes
Banner images were being overwritten.
Expected Behavior After Changes
Banner images have unique names based off the tenant so overwriting the name shouldn't be possible.
Screenshots / Video
Before
UIndy tenant has the banner image with filename being
cropped.jpgSearch tenant also has the same filename of
cropped.jpgAfter
The tenant is prepended to the filename
Another example
