-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SESSION 2: Work Types Workshop [DO NOT MERGE] #2
Open
ShanaLMoore
wants to merge
18
commits into
main
Choose a base branch
from
work-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the docker shell run command `bundle exec rails generate hyrax:work Thesis` to generate these files for your application.
A a prereq., We are setting up a config to use a local controlled vocabulary. We will create and use the metadata property for it later.
EXERCISE: Change the description of the thesis type
This commit adds comments to explain the controller and its options.
PART 1 - Add three metadata properties as defined in the comments/instructions.
This commit contains the answer for Defining Metadata in the model EXERCISE
See comments/instructions in thesis_form.rb for details
This commit adds contact_email, contact_phone, and department to the thesis_form's terms. Additionally it adds department and contact_email as required fields. Confirm changes by visiting the new/edit forms of the thesis work type in the browser.
See the comments for instructions. Let's hook up the controlled vocabulary for the 'department' property.
This commit includes correcting a previous mistake. The service file should've gone under the app/services directory. It also includes the code necessary to hook up the department controlled vocab property to the questioning authority local sub authority. Lastly, try statements are added to a partial otherwise an error will get thrown when trying to create a new work.
See comments in thesis_presenter.rb for instructions
This commit contains the code required to make the new properties appear on the Thesis work show page.
For example, if I selected 'hst' for the department value, it should be displayed as HISTORY on the show page.
Make the contact properties display to admin users only.
A user should be able find works by searching for a contact number.
Add and display department metadata property to the Collection model. A user should see which department the work belongs to in the search results.
Uncomment line 86 of the Gemfile and run bundle install
ShanaLMoore
changed the title
Work Types Workshop [DO NOT MERGE]
SESSION 2: Work Types Workshop [DO NOT MERGE]
Sep 5, 2023
ShanaLMoore
commented
Sep 20, 2023
ShanaLMoore
force-pushed
the
work-types
branch
2 times, most recently
from
September 20, 2023 18:48
dac5671
to
bdc46a5
Compare
This commit adds helper methods to department so that the value will display the terms instead of the id, in the catalog search index and facets. For example, "history" instead of "hst". You could write a spec for these methods for reassurance, and know that this is not the only way to accomplish this. With customizations the dev will often have to come up with solutions of their own. :gift: BONUS: Display QA term instead of id in search results and facets This commit adds helper methods to department so that the value will display the terms instead of the id, in the catalog search index and facets. For example, "history" instead of "hst". You could write a spec for these methods for reassurance, and know that this is not the only way to accomplish this. With customizations the dev will often have to come up with solutions of their own.
ShanaLMoore
force-pushed
the
work-types
branch
from
September 20, 2023 19:11
bdc46a5
to
ccd077a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch/PR was created as a progressive walk-through/guide to supplement the Samvera Training Workshop: Work Types.