Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

210-search-on-browse-tests #217

Merged
merged 1 commit into from
Feb 17, 2023
Merged

210-search-on-browse-tests #217

merged 1 commit into from
Feb 17, 2023

Conversation

DiemBTran
Copy link
Contributor

add 2 tests for browsing on the browse page. edit 1 test to include 'q' in the test's url

Story

Refs #210

I added 2 tests in cypress/e2e/browsing.cy.js:

  1. a user conducting a blank search on /browse
  2. a user conducting a queried search on /browse

I also edited a pre-existing test on line 30 of cypress/e2e/browsing.cy.js:

  • this test did not include the q in the URL for cy.url().should('include', '/browse?q=next'). On my local test runs, omitting the q from '/browse?q=next' led to a failure.

Expected Behavior Before Changes

  1. /browse did not have tests for searching on browse
  2. Line 30 test failed

Expected Behavior After Changes

  1. /browse has 2 tests for searching on browse
  2. Line 30 test passes

Screenshots / Video

Line 30 test: before and after I added 'q' to line 30's test's URL

webstore 2023-02-17 at 9 30 42 AM
webstore 2023-02-17 at 9 29 38 AM

Notes

Please let me know if my change to line 30 is incorrect or unexpected lol

@DiemBTran DiemBTran merged commit b925b6a into main Feb 17, 2023
@DiemBTran DiemBTran deleted the 210-search-on-browse-tests branch February 17, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants