-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Integrate wheel repairer #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LecrisUT
wants to merge
17
commits into
scikit-build:main
Choose a base branch
from
LecrisUT:feat/repair-wheel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45d04fd
to
04d9881
Compare
This comment was marked as resolved.
This comment was marked as resolved.
81f9407
to
9cc8ea9
Compare
Ready for review for this initial proposal. Further proposals that I want to build up from this
|
This was referenced Mar 18, 2025
eb9a769
to
a1506bd
Compare
I have dropped the documentation until #1022 is resolved. Implementation wise, this is the overall picture I had in mind for this feature (I couldn't figure how to get |
5bcd1d3
to
b9b5450
Compare
b9b5450
to
da7c156
Compare
henryiii
added a commit
that referenced
this pull request
Apr 15, 2025
I split the general documentation from #1009 --------- Signed-off-by: Cristian Le <git@lecris.dev> Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
`auditwheel` pacher forces `DT_RPATH`. Here instead we use `DT_RUNPATH` so that it can be overwritten by the user Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
This is needed because the last delocate package that supports python 3.8 does not have _get_rpaths Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
da7c156
to
36e8c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is:
sysconfig.get_path("platlib")
(pip fake venv is really annoying here)
CMAKE_INSTALL_RPATH_USE_LINK_PATH
Scripts
path.Maybe would be better to use the existing paths instead.
Do some other magic thatdelvewheel
doesAfaict, the only special thing it does is inject
os.add_dll_directory
. Cannot supportsubprocess.run
right now, but we could do it if we generate the wrappers. Will make a subsequent PR for that.To discuss:
scikit-build.repair-wheel
?auditwheel
/delocate
/delvewheel
directly, but these do not handle differently the packages in site-package vs externaldlevewheel
which creates separate dlls for each wheel.Depends-on: #1022 #1016