Skip to content

[WIP] Tighten file-api dataclasses #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

[DEBUG] Make file-api failure an error

2bdd65a
Select commit
Loading
Failed to load commit list.
Draft

[WIP] Tighten file-api dataclasses #1012

[DEBUG] Make file-api failure an error
2bdd65a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 11, 2025 in 0s

69.23% of diff hit (within 25.00% threshold of 81.16%)

View this Pull Request on Codecov

69.23% of diff hit (within 25.00% threshold of 81.16%)

Annotations

Check warning on line 269 in src/scikit_build_core/cmake.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/scikit_build_core/cmake.py#L267-L269

Added lines #L267 - L269 were not covered by tests

Check warning on line 48 in src/scikit_build_core/file_api/_cattrs_converter.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/scikit_build_core/file_api/_cattrs_converter.py#L48

Added line #L48 was not covered by tests

Check warning on line 64 in src/scikit_build_core/file_api/_cattrs_converter.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/scikit_build_core/file_api/_cattrs_converter.py#L58-L64

Added lines #L58 - L64 were not covered by tests

Check warning on line 73 in src/scikit_build_core/file_api/_cattrs_converter.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/scikit_build_core/file_api/_cattrs_converter.py#L73

Added line #L73 was not covered by tests