Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update vendored pyproject-metadata #917

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 27, 2024

  • Make sure it works
  • Support PEP 639
  • Support validation
  • Support multierrors

@LecrisUT
Copy link
Collaborator

Note-to-self: should have marked the Fedora license as Apache-2.0 AND MIT:

If we devendor it in Fedora we can reduce it. Probably the pyproject.toml should also be adapted, but I'm not sure how well PyPI supports dual licensing?

@henryiii
Copy link
Collaborator Author

PEP 639 covers dual licensing. :) Not sure when it will be common enough to use, though.

@henryiii henryiii force-pushed the henryiii/chore/pm090 branch 3 times, most recently from 0a967a3 to 1f6264f Compare September 27, 2024 21:21
@henryiii henryiii mentioned this pull request Sep 27, 2024
henryiii added a commit that referenced this pull request Sep 28, 2024
From #917. Also fixing the docs job to use the correct scikit-build-core
(local) version.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/chore/pm090 branch 2 times, most recently from 8611a08 to cbef242 Compare September 28, 2024 16:47
@LecrisUT
Copy link
Collaborator

LecrisUT commented Oct 2, 2024

I'm thinking what to do in this case and if we should be de-vendoring on the Fedora side. Would adding a check against importlib.metadata.version be ok with you?

@LecrisUT
Copy link
Collaborator

@henryiii I've added db4160b that clarifies and tracks the vendoring of pyproject-metadata. Feel free to move this commit when refactoring

@henryiii
Copy link
Collaborator Author

FWIW, I have permission from the original copyright holders to relicense under the same license as packaging.

@henryiii
Copy link
Collaborator Author

henryiii commented Nov 8, 2024

Packaging is out. So this is unblocked, will finish it up soon.

@henryiii henryiii force-pushed the henryiii/chore/pm090 branch from 2461b60 to 2b8de21 Compare November 13, 2024 21:41
@henryiii henryiii added this to the v0.11.0 milestone Nov 17, 2024
@henryiii henryiii marked this pull request as ready for review November 18, 2024 19:00
henryiii and others added 11 commits November 22, 2024 10:23
Signed-off-by: Henry Schreiner <[email protected]>

tests: update tests

Signed-off-by: Henry Schreiner <[email protected]>

tests: fixes

Signed-off-by: Henry Schreiner <[email protected]>

fix: support setting the name

Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/chore/pm090 branch from b70585c to 591a14d Compare November 22, 2024 15:23
@henryiii henryiii changed the title chore: update vendored pyproject-metadata feat: update vendored pyproject-metadata Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants