chore: check if 32bit right broadcasting test pass again #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Jan 24, 2025
|
Hm, it was the only thing that we changed related to 32bit I think. Anyway, the test passes again, so it seems to work 🎉 |
ianna
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
@pfackeldey - Thanks! The tests pass. Please merge it. Thank you.
pfackeldey
deleted the
pfackeldey/test_if_32bit_rightbroadcasting_works_again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only opened to see if the 32bit fix in #3270 is related in any way to the marked test failure for 32bit windows for right broadcasting.
If the tests pass now, I'll update this PR, so please don't merge!PR #3270 fixed it!