Add warning styles for parameter limits in params function #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDembinski
reviewed
May 17, 2025
HDembinski
reviewed
May 17, 2025
|
@Joshuazh Very nice patch, thanks. Please check comments, then it should ready to go after you adapted the tests. |
HDembinski
reviewed
May 17, 2025
|
I accidentally committed your changes to the develop branch with a minor improvement of mine. This caused this PR to show as Merged. Anyway, thank you for your nice contribution, it will appear in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #1088
below is an example