Implement automatic propagation of a started status from tasks to experiments and projects [SCI-11797] #8426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| def down | ||
| Project.where.not(started_at: nil).update_all(started_at: nil) | ||
| Experiment.where.not(started_at: nil).update_all(started_at: nil) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
| end | ||
|
|
||
| def down | ||
| Project.where.not(started_at: nil).update_all(started_at: nil) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
| .joins(experiments: { my_modules: :my_module_status }) | ||
| .where(started_at: nil) | ||
| .where.not(experiments: { my_modules: { my_module_statuses: { name: NOT_STARTED_STATUS } } }) | ||
| .update_all(started_at: started_at) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
| .joins(my_modules: :my_module_status) | ||
| .where(started_at: nil) | ||
| .where.not(my_modules: { my_module_statuses: { name: NOT_STARTED_STATUS } }) | ||
| .update_all(started_at: started_at) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
okriuchykhin
force-pushed
the
ok_SCI_11797
branch
from
abdf4ee to
de9ee07
Compare
…eriments and projects [SCI-11797]
okriuchykhin
force-pushed
the
ok_SCI_11797
branch
from
de9ee07 to
ae44356
Compare
artoscinote
previously approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-11797
What was done
Implement automatic propagation of a started status from tasks to experiments and projects