Fix permissions check in repository api [SCI-12136] #8661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +62,7 @@ def update | |||
| end | |||
|
|
|||
| def destroy | |||
| @inventory_item = @task.repository_rows.find(params.require(:id)) | |||
| @inventory_item = @repository_rows.find_by(id: params.require(:id)) | |||
There was a problem hiding this comment.
why it was changed to find_by?
| @@ -79,6 +80,10 @@ def load_my_module_repository_row | |||
| .find_by(my_module: @task) | |||
| end | |||
|
|
|||
| def load_repository_rows | |||
There was a problem hiding this comment.
change it to load_repository_row and load a single row here
aignatov-bio
force-pushed
the
ai-sci-12136-add-permission-checks-for-my-module-repository-rows
branch
2 times, most recently
from
9e3659f to
9931131
Compare
aignatov-bio
force-pushed
the
ai-sci-12136-add-permission-checks-for-my-module-repository-rows
branch
from
9931131 to
db24ebd
Compare
| raise PermissionError.new(Repository, :read) unless @inventory_item && can_read_repository?(@inventory_item.repository) | ||
|
|
||
| @task.my_module_repository_rows.find_by(repository_row: @inventory_item).destroy! | ||
| @task.my_module_repository_rows.find_by(repository_row: @repository_row).destroy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-12136
What was done
Fix permissions check in repository api