Handle project "visibility" property backward-compatibility on API [SCI-12041] #8664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignatov-bio
force-pushed
the
ai-sci-12041-add-support-of-project-visibility-in-api
branch
from
b40ad0f to
20c9b71
Compare
| project.team_assignments.create!( | ||
| team: project.team, | ||
| assignable: project, | ||
| user_role_id: UserRole.predefined.find_by(name: I18n.t('user_roles.predefined.viewer')).id, |
There was a problem hiding this comment.
don't we have find_predefined_viewer_role helper?
| if project_params[:visibility] == 'visible' | ||
| project.team_assignments.create!( | ||
| team: project.team, | ||
| assignable: project, |
There was a problem hiding this comment.
isn't it already prefilled?
| elsif project_params[:visibility] == 'visible' && !has_team_assignment | ||
| @project.team_assignments.create!( | ||
| team: @project.team, | ||
| assignable: @project, |
aignatov-bio
force-pushed
the
ai-sci-12041-add-support-of-project-visibility-in-api
branch
from
20c9b71 to
28dab56
Compare
| end | ||
|
|
||
| def update | ||
| @project.assign_attributes(project_params) | ||
| has_team_assignment = @project.team_assignments.any? |
There was a problem hiding this comment.
don't you need to filter by team?
| @project.save! | ||
|
|
||
| if project_params[:visibility] == 'hidden' && has_team_assignment | ||
| @project.team_assignments.find_by(assignable: @project).destroy! |
There was a problem hiding this comment.
why are you looking by assignable if it is already collection belonging the specific project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-12041
Handle project "visibility" property backward-compatibility on API