Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: drop partial colibri implementation #4372

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Jul 25, 2023

A partial implementation of colibri was added in a series of PRs (#3446, ..., #3905). This has not been sufficiently completed to become operational, i.e. the colibri implementation in this repository has effectively remained dead code.
The colibri prototype was further developed in a fork, https://github.com/netsec-ethz/scion, and changes have no longer been upstreamed. Consequently the remaining colibri code here has become stale and keeping this is no longer of great use.


This change is Reviewable

A partial implementation of colibri was added in a series of PRs (scionproto#3446,
..., scionproto#3905). This has not been sufficiently completed to become
operational, i.e. the colibri implementation in this repository has
effectively remained dead code.
The colibri prototype was further developed in a fork,
github.com/netsec-ethz/scion, and changes have no longer been upstreamed.
Consequently the remaining colibri code here has become stale and
keeping this is no longer of great use.
Copy link
Contributor

@juagargi juagargi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this out.
I would also remove pkg/experimental/colibri, doc/dev/design/ColibriService.md and anything pointing to them. The docs are also of no use for the new QoS and implementation.

Reviewed 61 of 61 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matzf)

Copy link
Contributor Author

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.
I've marked the design document as outdated. We're keeping outdated design docs around as sort of an archive.

Reviewable status: 61 of 63 files reviewed, all discussions resolved (waiting on @juagargi)

Copy link
Contributor

@juagargi juagargi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matzf)

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matzf)

@matzf matzf merged commit 708bdc2 into scionproto:master Jul 27, 2023
1 check passed
@matzf matzf deleted the colibri-drop branch July 27, 2023 14:53
@matzf matzf mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants