-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new c'tors to LinExpr #36
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 95.62% 96.13% +0.50%
==========================================
Files 10 10
Lines 183 207 +24
Branches 48 59 +11
==========================================
+ Hits 175 199 +24
Misses 3 3
Partials 5 5
|
@TonyCongqianWang you might want to have a look into this |
I'll try to do it tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Not having spans should not be a big drawback since copying variables is not going to be very expensive. Using std::vector should allow enough flexibility for most use cases
Add new c'tors to LinExpr to speed-up the creation of expressions with multiple variables.
Fixes #32
This is an alternative implementation of #34