Separate handling of non-default nodejs to sync Fedora 41 Dockerfiles #477
+142
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request validationFailed🔴 Failed or pending statuses - |
|
[test][test-upstream] |
Testing Farm results
|
|
Let's try one more time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the changes in the nodejs18 RPMs to get to the stable repo first, they're in bodhi now: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e21c7819e3
The update ^^ fixes a problem that nodejs18 pulled in nodejs package as a dependency.
With that, we can use F41 as a base for all Node.js versions.
Since this sync to the newest Fedora required to rework the mechanism of "making the alternative Node.js to be the only one in the container and without version in CLI names", aka adding symlinks and testing that we actually have a correct version available, I've separated these steps into a separate script, rather than making the Dockerfile.fedora more complex. This did not seem to be required in RHEL/CXS versions, but once we put new alternative versions to RHEL 10, we might reuse this script there as well (i.e. create RHEL10/C10S dockerfile from the Fedora Dockerfile).