Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.gitignore): add more autotool files #792

Merged
merged 2 commits into from
Sep 3, 2022
Merged

Conversation

akinomyoga
Copy link
Collaborator

The filenames compfile, depcomp, ltmain.sh, and config.{guess,sub} are added in .gitignore. Also, I collected the autotool-related entries in a section.

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've nothing against this in principle, but I'd like to understand which versions or scenarios cause the files compile, depcomp, config.guess, config.sub, and ltmain.sh to appear. They do not for me in Ubuntu 20.04 or Fedora dev, autoreconf -i; ./configure; make.

@akinomyoga
Copy link
Collaborator Author

Ah, OK. I do somehow have these files but couldn't reproduce them in a clean bash-completion repository (with autotools from Fedora 36), but now I have identified why I have these files. To investigate the historical behavior of cryptsetup --help & man cryptsetup for #759, I cloned a repository of cryptsetup in a subdirectory and tried to build it. It somehow seems to create the related files at an upper level. In short, I could reproduce them by the following steps.

bash-completion$ git clone [email protected]:cryptsetup/cryptsetup.git
bash-completion$ cd cryptsetup
cryptsetup$ ./autogen.sh

Running autoreconf -i in the cryptsetup directory instead of autogen.sh also rewrites the files of the parent directory. I did not know autoreconf -i could rewrite the files outside the directory.

@akinomyoga
Copy link
Collaborator Author

OK, I think there is no reason to add these files created by autoreconf -i of external projects in .gitignore. I just dropped these files. I keep this PR open as it still has some changes though it is now reduced to just a cosmetic update.

@scop scop merged commit 2d6ac65 into scop:master Sep 3, 2022
@scop
Copy link
Owner

scop commented Sep 3, 2022

Thanks!

@akinomyoga akinomyoga deleted the gitignore branch September 3, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants