-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth Login #95
base: develop
Are you sure you want to change the base?
OAuth Login #95
Conversation
#14 fix on travis file typo
fix travis file errors and add build status to readme
Backend unit tests: Login and signup
technology used:- Node Angular Firebase Python
Indentations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
However would this PR be better if it also included the frontend part so that the functionality can be tested completely before merging? Any thoughts @malithsen ?
Looks good to me! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
@OshanIvantha @mpiplani thanks a lot! |
@VibhorCodecianGupta This looks good, and thank you for the contribution 👍 |
I'll put the frontend code too then, thanks! |
@malithsen @OshanIvantha I was recently getting on this, then I realised that new users can only be created by a logged in admin. With this logic in place, social login is not of much use, reason being that no new user can login with social accounts until and unless the admin has created one. As for existing users, they can just connect their social accounts and probably login only after the admin has created a user. |
fixes #73