Skip to content

Adding authentication to user end points. List, GetUser, Count and Delete #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding authentication to user end points. List, GetUser, Count and Delete #166

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14a9f03
Adding authentication to list and count methods
ShanuWije May 15, 2021
66e2962
Added check to ensure only admin can delete users
ShanuWije May 15, 2021
55527de
getUser by id endpoints needs to be authenticated since this can be u…
ShanuWije May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions flask-backend/api/routes/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,13 @@ def getUser(id):
'users': result})

@user.route('/count', methods=["GET"])
@login_required
def count():
return jsonify({'status':200,
'total_users':User.query.count()})

@user.route('/list', methods=["GET"])
@login_required
def list():
all_users = User.query.order_by(User.timestamp).all()
result = users_schema.dump(all_users)
Expand Down Expand Up @@ -189,14 +191,16 @@ def roleupdate():
@user.route('/delete', methods=['POST'])
@login_required
def deleteuser():
# Check if email is provided or not
try:
req = request.get_json()
email = str(req['email'])
except:
return 'please provide email', 400
if current_user.role == 'adimn':
# Check if email is provided or not
try:
req = request.get_json()
email = str(req['email'])
except:
return 'please provide email', 400

user = User.query.filter_by(email=email).first()
db.session.delete(user)
db.session.commit()
return 'user deleted', 202
user = User.query.filter_by(email=email).first()
db.session.delete(user)
db.session.commit()
return 'user deleted', 202
return 'You are not an admin.', 409