Merge branch 'jcutrell-sourcesrc-notification'

scottjehl · Jul 15, 2014 · a3b3c30 · a3b3c30
2 parents cdf8e64 + 750fca1
commit a3b3c30
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/picturefill.js b/src/picturefill.js
@@ -419,6 +419,10 @@
 			if ( source.nodeName.toUpperCase() !== "SOURCE" ) {
 				continue;
 			}
+			// if it's a source element that has the `src` property set, throw a warning in the console
+			if ( source.getAttribute( "src" ) !== null && typeof console !== undefined ){
+				console.warn("The `src` attribute is invalid on `picture` `source` element; instead, use `srcset`.");
+			}
 
 			var media = source.getAttribute( "media" );
 

diff --git a/tests/index.html b/tests/index.html
@@ -63,6 +63,12 @@
 		<source srcset="bar"/>
 	</picture>
 
+	<div class="src-source-check">
+		<picture>
+			<source src="foo"/>
+		</picture>
+	</div>
+
 </div>
 
 <script src="../src/picturefill.js"></script>