Move scratch-asset-types to Github Actions #16
Conversation
delasare
changed the title
.github/workflows/build.yml
Outdated
| npm --production=false install | ||
| npm --production=false update | ||
| npm --production=false prune |
There was a problem hiding this comment.
Since this has a package-lock.json now, I think this should switch to npm ci:
| npm --production=false install | |
| npm --production=false update | |
| npm --production=false prune | |
| npm --production=false ci |
There was a problem hiding this comment.
i moved everything to dependencies rather than devDependencies since there are only 5. Eslint was failing because it could not be found. IIRC npm ci does not include devDependncies with node_env=production.
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "test": "make test" | ||
| "test": "tap ./test/unit/*.js", |
There was a problem hiding this comment.
Hmm... it's kind of awkward to have this out of sync with what the Makefile does. It doesn't currently matter because ./test/functional/ and ./test/integration/ don't exist, but it seems like it's setting the stage for a mistake in the future. I'd suggest either migrating everything out of Makefile and deleting it, or changing the test script back to make test.
There was a problem hiding this comment.
I agree its a little awkward. I'll have to go back and test this - I don't think Make was working and that's why I switched it. (sorry its been a while 😂 )
There was a problem hiding this comment.
I fixed this. Went back to Make. :)
Resolves
https://scratchfoundation.atlassian.net/browse/ENG-50
Proposed Changes