Use fixupSVGString from scratch-svg-renderer #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
import-fixup
branch
from
d606825
to
451ec18
Compare
adroitwhiz
force-pushed
the
import-fixup
branch
from
451ec18
to
661a53e
Compare
10 tasks
|
Update: we're doing a similar thing now, with a new sanitization function that is exported from scratch-svg-renderer and which is run on image upload. There are still some differences between rendering in the stage/tiles and in the paint editor, however -- I'm not sure where the problem is with those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on scratchfoundation/scratch-svg-renderer#209, scratchfoundation/scratch-svg-renderer#210, and scratchfoundation/scratch-gui#6556
Resolves
Resolves #1269
Proposed Changes
This PR changes the
importSVGfunction to use thefixupSvgStringfunction fromscratch-svg-rendererinstead of applying its own fixes to the imported SVG string.Reason for Changes
See the rationale in #210. This should result in all renderable SVGs also being editable in the paint editor--no more SVGs that render but crash the paint editor. Now, either an SVG is parseable or it'll be replaced with the grey question mark asset everywhere.
Test Coverage
Tested manually