Export fixupSvgString from module #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #97
EDIT: also resolves #50
Proposed Changes
This PR exports the
fixupSvgStringfunction from this module, allowing it to be used in the paint editor and other repos (I think the GUI may benefit from using it in the sprite selector panel, but I can't remember).Reason for Changes
Currently, the paint editor has its own "fixup SVG string" step which has diverged from the
fixupSvgStringfunction in this repo. This results in certain SVGs being displayed properly in the player, but crashing the paint editor when you try to modify them.Allowing the paint editor to call
fixupSvgStringfrom here will ensure that all SVGs renderable here will also be editable in the paint editor without it crashing upon import.