Eliminate contact judgments between the sprite and mouse pointer off-stage. #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue.
There is a method to detect that the mouse pointer has moved to an off-stage object by placing the sprite off-stage.
Therefore, it is necessary to correct the internal mouse coordinates to in-stage coordinates before contact determination.
Proposed Changes
Correct the mouse pointer to in-stage coordinates starting at line 745 of /src/sprites/rendered-target.js.
Reason for change
Because there are many actions in Japan, such as detecting the report button and preview button, where hearts detect stars, add staging and items, and other actions that may activate malicious plans.