Fix crash when tts language is not a string#5426
Open
husqwc wants to merge 1 commit intoscratchfoundation:developfrom
Open
Fix crash when tts language is not a string#5426husqwc wants to merge 1 commit intoscratchfoundation:developfrom
husqwc wants to merge 1 commit intoscratchfoundation:developfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Setting the tts language to something other than a string causes a crash
For example, in this script, the sprite never says meow:
Proposed Changes
a .toString() has been added to fix the crash
Reason for Changes
.toLowerCase() no longer crashes, and there is always an output for .toString() in JS
Test Coverage
No tests so far