Skip to content

fix: parse root dir even if inside a node_modules folder #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KManolov3
Copy link

@KManolov3 KManolov3 commented Jan 22, 2025

Resolves

NOTE: This may not need to be merged in case scratch-android starts using scratch-gui from an npm package, instead of a git commit as it does currently.

A dependency for https://scratchfoundation.atlassian.net/browse/UEPR-139

Proposed Changes

Force babel to parse the root folder, even if inside a node_modules futher up the hierarchy.

Reason for Changes

In another repo - scratch-android - we are manually building scratch-gui by going inside its folder (which is inside node_modules of scratch-android) and making a webpack build. After the update of scratch-gui to use scratch-webpack-config that stopped working, since currently there is a rule which prevents babel from parsing folders inside a node_modules folder. However that is not relative to the the pwd so if the project we are trying to build is inside a node_modules further up the chain, babel will not transpile the necessary files (e.g. .jsx files).

@KManolov3
Copy link
Author

This fix is not needed anymore, since we are switching out from building GUI from node_modules in scratch-android

@KManolov3 KManolov3 closed this Apr 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants