Refactor renderHomepageRows to use dynamic rows #9878
Conversation
toggle Featured Rows due to server issues
|
@adzhindzhi This is very important as the rows for Featured Projects and Featured Studios are going through issues (Though featured studios is down right now only but it's best to tackle both rows incase Featured Projects fail.). |
src/views/splash/presentation.jsx
Outdated
| sharedByFollowing: [], // "Projects by Scratchers I'm Following" | ||
| shouldShowCommunityRows: false | ||
| shouldShowCommunityRows: false, | ||
| shouldShowFeaturedRows: false |
There was a problem hiding this comment.
Hi @rosics-code, thank you for your contribution! In this change, the shouldShowFeaturedRows prop is always set to false, which ends up hiding the featured sections even when the data loads successfully. If we want to hide those sections, it should be based on whether the featured content was actually fetched, rather than disabling them by default. Also, since featured studios and featured projects are calculated separately, one of them might be available when the other isn’t, so I don't think we should hide both sections if only one of them fails. Thanks again for contributing!
There was a problem hiding this comment.
Maybe we could only do studios for now?
2 participants
toggle Featured Rows due to server issues
Resolves:
It resolves things not loading on the homepage completely .
Changes:
Uses rows.push like WTCIL and WTCIF and to toggle it.
Test Coverage:
Before:
After: