Make the users.json file permanent #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the setup potentially copy over the example user file, just ask the user to set it up himself. This stops mistakes from happening with `--force`. Also mount the file into the container instead of copying it, so that an update just needs a container restart and not a rebuild. Hence, remove the rebuilding from the start script and add it as a developer-intended command to the npm scripts (since the only reason to rebuild would be if the pushStats scripts is edited).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the setup potentially copy over the example user file, just ask the user to set it up himself. This stops mistakes from happening with
--force.Also mount the file into the container instead of copying it, so that an update just needs a container restart and not a rebuild. Hence, remove the rebuilding from the start script and add it as a developer-intended command to the npm scripts (since the only reason to rebuild would be if the pushStats scripts is edited).