Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-2055] Replacing custom database tracing with dd-trace-go/contrib library #106

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[SERF-2055] Replacing custom database tracing with dd-trace-go/contrib library #106

merged 2 commits into from
Jun 14, 2024

Conversation

laynax
Copy link
Contributor

@laynax laynax commented Jun 12, 2024 •
edited
Loading

Description

By now, we've been using our own trace since we were using an outdated gorm version. Now that we are to the (almost) latest gorm version, we can start using community supported tracing.
A new version will be released after merging this PR.

Testing considerations

Code is tested on document-search staging, having spans with the new library.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with [good commit messages][commit messages]
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@laynax laynax requested a review from a team as a code owner June 12, 2024 14:47
@laynax laynax requested review from fotos and Neurostep June 12, 2024 14:47
fotos
fotos reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I did a quick pass and left 2 comments. 💬

pkg/database/gorm.go Show resolved Hide resolved
pkg/database/gorm.go Outdated Show resolved Hide resolved
pkg/database/gorm.go Outdated Show resolved Hide resolved
@laynax laynax requested review from Neurostep and fotos June 13, 2024 09:25
fotos
fotos previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

@laynax laynax force-pushed the laynax/SERF-2055/DgormD branch 2 times, most recently from 145a375 to ac1cad5 Compare June 14, 2024 09:51
Neurostep
Neurostep approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@laynax laynax merged commit f6ca9ea into main Jun 14, 2024
6 checks passed
@laynax laynax deleted the laynax/SERF-2055/DgormD branch June 14, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neurostep Neurostep Neurostep approved these changes

@fotos fotos fotos left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laynax @fotos @Neurostep