Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-3090] Use role base access in AWS deployment #91

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[SERF-3090] Use role base access in AWS deployment #91

merged 1 commit into from
Dec 21, 2023

Conversation

helenff
Copy link
Contributor

@helenff helenff commented Dec 21, 2023 •
edited
Loading

Description

Update CI to assume the deployer role via OIDC to avoid storing sensitive AWS key credentials in repository secrets.

Testing considerations

  • Release pipeline completed sucessfully

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Commits are squashed in a logical and understandable history
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@helenff helenff marked this pull request as ready for review December 21, 2023 09:21
@helenff helenff requested a review from a team as a code owner December 21, 2023 09:21
@helenff helenff requested a review from laynax December 21, 2023 09:21
terranisu
terranisu approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@helenff helenff merged commit 11792c3 into main Dec 21, 2023
4 checks passed
@helenff helenff deleted the helen/SERF-3090/oidc branch December 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terranisu terranisu terranisu approved these changes

@laynax laynax Awaiting requested review from laynax laynax is a code owner automatically assigned from scribd/service-foundations

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helenff @terranisu