🐛 处理on事件的移除

scriptscat · Apr 29, 2024 · c69c208 · c69c208
1 parent 03987b0
commit c69c208
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/runtime/content/utils.test.ts b/src/runtime/content/utils.test.ts
@@ -9,6 +9,7 @@ describe("proxy context", () => {
       console.log("eval");
     },
     addEventListener: () => {},
+    removeEventListener: () => {},
     location: "ok",
   };
   init.set("onload", true);
@@ -25,6 +26,8 @@ describe("proxy context", () => {
     _this["onload"] = "ok";
     expect(_this["onload"]).toEqual("ok");
     expect(global["onload"]).toEqual(null);
+    _this["onload"] = undefined;
+    expect(_this["onload"]).toEqual(undefined);
   });
 
   it("update", () => {

diff --git a/src/runtime/content/utils.ts b/src/runtime/content/utils.ts
@@ -332,7 +332,14 @@ export function proxyContext(
         }
         // 只处理onxxxx的事件
         if (has(global, name) && name.startsWith("on")) {
-          global.addEventListener(name.slice(2), val);
+          if (val === undefined) {
+            global.removeEventListener(name.slice(2), thisContext[name]);
+          } else {
+            if (thisContext[name]) {
+              global.removeEventListener(name.slice(2), thisContext[name]);
+            }
+            global.addEventListener(name.slice(2), val);
+          }
           thisContext[name] = val;
           return true;
         }