-
Notifications
You must be signed in to change notification settings - Fork 213
修正 ScriptList 重绘、图标显示等问题 + 其他视觉元素修改 #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112de79
to
66fbcae
Compare
变化有点大,变成了紧凑的了,不过也挺好的,可以接受 不过在点击开启/运行启动的时候,页面会刷新一下,之前的做法应该是只在操作的按钮上loading,不会刷新页面(似乎是loading的原因),这个loading直接删除会有问题吗? |
太棒了!除了上面的loading,一切都很好,现在popup打开也非常快 |
loading 只是做一個效果 可以不加。沒影響 https://arco.design/react/components/table#%E8%A1%A8%E6%A0%BC%E5%B1%9E%E6%80%A7 沒實際刷新。只是一個視覺效果 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
把代码改来改去终於处理掉重绘问题
之前有把 columns 的width拆出来不过还是算了。保持newColumns dealColumns
非React的改动很简单,把批次读icon的以icon取得顺序就好。失效的Icon不会卡死其他icon
React的部份最大的坑是,
因为用了Dragaable,所以ArcoTable裡 components的table/tbody/row 放了React自订元件
如果这个元件是放在
function ScriptList() { ... }
裡,就会在改column width时重绘整个table只要把东西拉回顶层,ScriptList裡的变量改用Context形式传过去就好
另一个坑是,
getScriptListColumnWidth 那个是异步,所以render时会先render最初那个大小
render中途得到 getScriptListColumnWidth 后又再render一次
所以加了 canShowList 就可以保证 getScriptListColumnWidth 是完成后才 render
此外,因为我们用的是较高级的dnd-kit, 没有官方示例的那个简单易用,所以要自订 DragHandle, 也是要用Context传东西的
另外,拖拉改回把最左手边,配合正常用户习惯
加了
@dnd-kit/modifiers
是为了限制拖拉只有上下不会有左右注意: 当开啟option page 时,因图标在读取,而popup弹不出来的问题还未有解决方法。不打算在这PR修正(仅最初,问题不大)
其他
闊度 step={5}
74f9b0e
apply_to_run_status word-wrap
c2cc52e
loading={loading}
调整padding 令 scriptlist 有更多空间显示资料
取消filter 打字栏动画效果 (共通)
修正fixed-layout 中 name 的最小阔最大阔 (col )