Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use overridden chainConfig in standardTraceBlockToFile #871

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

0xmountaintop
Copy link
Member

@0xmountaintop 0xmountaintop commented Jul 1, 2024

1. Purpose or design rationale of this PR

chainCfg has been overridden, we should use the overridden one.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Haoyu/fix_chaincfg fix(api): use overrided chainConfig in standardTraceBlockToFile Jul 1, 2024
@0xmountaintop 0xmountaintop changed the title fix(api): use overrided chainConfig in standardTraceBlockToFile fix(api): use overridden chainConfig in standardTraceBlockToFile Jul 1, 2024
Thegaram
Thegaram previously approved these changes Jul 5, 2024
@@ -769,7 +769,7 @@ func (api *API) standardTraceBlockToFile(ctx context.Context, block *types.Block
// Execute the transaction and flush any traces to disk
vmenv := vm.NewEVM(vmctx, txContext, statedb, chainConfig, vmConf)
statedb.SetTxContext(tx.Hash(), i)
l1DataFee, err := fees.CalculateL1DataFee(tx, statedb, api.backend.ChainConfig(), block.Number())
l1DataFee, err := fees.CalculateL1DataFee(tx, statedb, chainConfig, block.Number())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only override that we might apply is BerlinBlock, is that intended?

Copy link
Member Author

@0xmountaintop 0xmountaintop Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. that's the only one override i find in this file
  2. the override code (L733~734) is from 3-year-ago upstream, not made by us.
  3. in L770, the original code uses chainConfig, but L772 is introduced by use and it's using api.backend.ChainConfig()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it more generic? https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/api.go#L761-L769 Or is that a lot of extra work?

Copy link
Member Author

@0xmountaintop 0xmountaintop Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes on "upstream" branch it's more generic, we can also update here on develop branch. I can update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants