feat: log broadcast files #12
Conversation
| @@ -22,6 +22,14 @@ if [ "${BATCH_SIZE}" = "" ]; then | |||
| BATCH_SIZE="100" | |||
| fi | |||
|
|
|||
| if [ "${CHAIN_ID_L1}" = "" ]; then | |||
There was a problem hiding this comment.
Let's not use defaults here. We can error if it is not provided.
In the broadcast/... path maybe you can also match using * since most likely there will only be 2 subfolders.
There was a problem hiding this comment.
Yes, but it seems hard to determinate which one is L1 broadcast file and which one is L2 broadcast file.
There was a problem hiding this comment.
btw, environment variable CHAIN_ID_L1 and CHAIN_ID_L1 are set by helm chart now when launching the container.
There was a problem hiding this comment.
Can we do something like this?
echo ""
echo "Broadcast files:"
cat broadcast/DeployScroll.s.sol/*/run-latest.json
Or if it doesn't work we can use CHAIN_ID_L1 and fail if it is not set.
|
Morty wants to close this for now, as we'll be achieving the logs through a more docker-native way, now that this isn't part of the k8s cluster. |
Problem:
Some of clients want log files of the contracts that were successfully deployed, so they could get to know the contracts deployment process in detail.
Solution:
Foundry do provide a file -- broadcast/DeployScroll.s.sol/$CHAIN_ID_L1/run-latest.json to cache deployment information.
It doable to persist the file to a node, but kubernetes is supposed to be a cluster of machines, so it will be rather complex to get it.
So here we cat broadcast files in docker, this would be easy to implement, and client shall get those information in deploy-contracts pod logs.