Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Forms #21

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Implement Forms #21

merged 10 commits into from
Aug 21, 2024

Conversation

PleaseInsertNameHere
Copy link
Contributor

@PleaseInsertNameHere PleaseInsertNameHere commented Aug 21, 2024 •
edited
Loading

This PR implements logic to easily send and handle forms.

Sending forms:

  • SimpleForm
  • ModalForm
  • CustomForm

Handling forms:

  • Retrieving packet from packet handler
  • Event
  • Consumers for directly handling responses
  • SimpleForm (processing)
  • ModalForm (processing)
  • CustomForm (processing)

@PleaseInsertNameHere PleaseInsertNameHere marked this pull request as draft August 21, 2024 14:10
@AzaleeX AzaleeX self-requested a review August 21, 2024 14:25
@AzaleeX AzaleeX added Status: Incomplete Issues missing necessary information. Type: Todo Tasks that need to be completed. Category: API Issues and discussions related to the software's API. labels Aug 21, 2024
@JblusItsMe JblusItsMe self-requested a review August 21, 2024 14:54
@JblusItsMe
Copy link
Member

Thank you for contributing to this project, we are very grateful, we will be happy to validate your pull request once it is completed. Thank you very much 😉

@AzaleeX AzaleeX marked this pull request as ready for review August 21, 2024 15:06
@PleaseInsertNameHere
Copy link
Contributor Author

I will finish this PR as soon as the packet handler for the main game exists

@PleaseInsertNameHere
Copy link
Contributor Author

The code for the PacketHandler is now implemented. It only needs to be passed specifically to the method as soon as the handler exists. Other than that, the PR is now done and requires testing once the server is joinable.

Usage:

@Override
public PacketSignal handle(ModalFormResponsePacket packet) {
    return Form.handleIncomingPacket(this.player, packet);
}

@JblusItsMe JblusItsMe merged commit 9b0f68e into sculkmp:main Aug 21, 2024
1 check passed
AzaleeX added a commit that referenced this pull request Sep 29, 2024
@AzaleeX @JblusItsMe
@dependabot @SenseiTarzan @PleaseInsertNameHere @tunikakeks
push (#29)
7ffdb77 
* fix log4j2.xml packages

* add new file to .gitignore

* The server opens an interfaces to make the server visible

* fix shutdown server

* get player skin for ClientChainData

* add dependendy com.google.guava

* ProtocolInfo.getPacket(int protocol) for compare player protocol and server protocol

* Init ChainData

* add new function

* Enable server connection

* feat(readme): small readme update
added the image of the sculk block + renamed the project in Sculk and not in Sculk-MP, giving it the pmmp aspet

* feat(readme): update logo png

* fix(log4j2): error using log4j2 which caused an error in the launch console + style update which will be a bit more compact

* feat(Sculk): update file to remove System.out which returns the same thing as log.info + use Code-Name

* add(Sculk): a runner for Sculk to make it more practical

* Update log4j2.xml

* add event system

* fix text

* import aikar timings

* fix co.aikar.timings

* fix login

* add getScheduler() function

* Adding thread backup

* Create player interface for player.class

* Timings.java fix

* add events

* add AsyncTask system

* fix LoginData & PacketHandler

* Update Server.java

* feat(vscode): delete unnecessary vscode files

* Bump com.nimbusds:nimbus-jose-jwt from 9.10.1 to 9.37.2

Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.10.1 to 9.37.2.
- [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt)
- [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2..9.10.1)

---
updated-dependencies:
- dependency-name: com.nimbusds:nimbus-jose-jwt
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Create publish.yml

* Update build.yml (#11)

* fix build and add post artifact on Action

* feat(colors): new minecraft colors added (#14)

* fix(server): modify server folder (#15)

* style(file header): Sculk-MP -> Sculk (#17)

* feat(server-properties): Creation of ServerProperties System (#18)

* feat(server-properties): creation of a ServerProperties system with enums

* feat(server-properties): delete "on" and "off"

* feat(server-properties): add "SPAWN_ANIMALS" and "SPAWN_MONSTERS"

* Readme Update (#20)

* style(Update badges with sculk colors + add contributors below):

* feat: edit badge color

* feat: edit SculkMP -> Sculk

* fix server ip and port

* Update Timings.java

* login send, next step world for login

* Update form milestone in readme

* Implement Forms (#21)

* impl: form sending logic

* impl: Form response handling

* Add Getters for CustomResponse

* Tried to reduce code complexity

* Player: give formId a default value

* Add consumers

* Add license headers

* impl: Code for PacketHandler

* Rename method name

* Update LoginData & Bedrock Interface

* Fix async task collect

* add packet connection

* feat: Base plugin + plugin manager (#22)

* fix string in PluginLoader

* (In dev) LoginPacketHandler JWT

* Update README.md

* Update README.md

* rename all fire function (Event) -> call

* Update handler and fix resources pack loading

Co-Authored-By: AzaleeX <[email protected]>
Co-Authored-By: Sensei Tarzan <[email protected]>

* Create spawn response packet

Co-Authored-By: Sensei Tarzan <[email protected]>

* login Success

* Create attribute

* Create hunger attribute

* generate Human file and extends

* Add new event (PlayerExhaustEvent)

* send player attributes

* Implement plugin api version check (#23)

* feat: Base plugin + plugin manager

* Try to reduce complexity

* feat: plugin api version check

* comment unfinished line of code

---------

Co-authored-by: PleaseInsertNameHere <[email protected]>

* Attribute (#24)

* Add experience attribute

* init hungerManager and experienceManager to function initEntity()

* Define default EntityFlag.BREATHING true (#25)

* Add experience attribute

* init hungerManager and experienceManager to function initEntity()

* Define default EntityFlag.BREATHING true

* 🔀 Add support chat and command integration (#26)

* add onUpdate() and call PlayerChatEvent.java

* Player login console information

* add ChatFormatter/StandardChatFormatter for PlayerChatEvent

* move player class

* Update Player::onChat()

* Change BedrockServerSession -> SculkServerSession

* Base logic command

* Sends message to the console when players are typing in chat

* Creation of the command system and version command

* register command and add Server::dispatchCommand()

* Add support Json message

Co-Authored-By: Sensei Tarzan <[email protected]>

* add CommandRequestPacket

* add Player::sendAnnouncement Player::sendWhisperPlayer::sendMessageTranslationPlayer::sendMessageSystem

Co-Authored-By: Sensei Tarzan <[email protected]>

* Add version command

* Fix display translation message

Co-Authored-By: Sensei Tarzan <[email protected]>

* Fix command data

Co-Authored-By: Sensei Tarzan <[email protected]>

* Add execute command in console

Co-Authored-By: Sensei Tarzan <[email protected]>

---------

Co-authored-by: Sensei Tarzan <[email protected]>

* feat(submotd): Add `getSubMotd` method and fix level name retrieval (#27)

* feat(submotd): added getSubMotd

* fix: Correction of the world name on the startgame package

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: JblusItsMe <[email protected]>
Co-authored-by: JblusItsMe <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sensei Tarzan <[email protected]>
Co-authored-by: PleaseInsertNameHere <[email protected]>
Co-authored-by: KeksDev <[email protected]>
Co-authored-by: Sensei Tarzan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JblusItsMe JblusItsMe JblusItsMe approved these changes

@AzaleeX AzaleeX Awaiting requested review from AzaleeX

Assignees
No one assigned
Labels
Category: API Issues and discussions related to the software's API. Status: Incomplete Issues missing necessary information. Type: Todo Tasks that need to be completed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PleaseInsertNameHere @JblusItsMe @AzaleeX