-
Notifications
You must be signed in to change notification settings - Fork 164
(fix): check xarray installation when using any xarray-dependent code #1991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
- Coverage 87.11% 85.34% -1.78%
==========================================
Files 46 46
Lines 6947 7001 +54
==========================================
- Hits 6052 5975 -77
- Misses 895 1026 +131
🚀 New features to boost your workflow:
|
The codecov is complaining because we need a similar fix to scverse/scanpy#3607 (comment) where we have "min-deps" i.e., no xarray dask etc. |
Yeah! Would you do the equivalent PR to scverse/scanpy#3607 or should I? |
I'm happy to do it @flying-sheep. |
for more information, see https://pre-commit.ci
…ta into ig/error_on_read_elem_lazy
@@ -15,7 +15,7 @@ scripts.clean = "git restore --source=HEAD --staged --worktree -- docs/release-n | |||
|
|||
[envs.hatch-test] | |||
default-args = [ ] | |||
features = [ "dev", "test-min" ] | |||
features = [ "test-min" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev
was installing test
which was installing xarray
, so I removed it. I couldn't see a reason to have it, but it's possible there is some sort of unknown use-case for it (to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was also a pretty big whif on our test suite since we weren't testing without xarray
118a304
to
1f91433
Compare
The awkward array docs are down (?) so we'll just rerun tomorrow |
Uh oh!
There was an error while loading. Please reload this page.