Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically cancel running CI jobs on new commit #158

Merged
merged 9 commits into from
Apr 13, 2023
Merged

automatically cancel running CI jobs on new commit #158

merged 9 commits into from
Apr 13, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Apr 6, 2023 •
edited
Loading

⚠️ blocked by #138 ⚠️ -- DO NOT MERGE

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#45

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@grst grst marked this pull request as ready for review April 6, 2023 18:47
@grst grst marked this pull request as draft April 6, 2023 19:01
@grst grst marked this pull request as ready for review April 13, 2023 10:53
@grst grst requested a review from ivirshup April 13, 2023 10:54
flying-sheep
flying-sheep approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. With the group defined this way they don’t get into each other’s way.

E.g. when one workflow is modified to only run on some commits and the other runs on all of them, the one running on all commits doesn’t cancel the other one.

@flying-sheep flying-sheep merged commit bc00313 into main Apr 13, 2023
@flying-sheep flying-sheep deleted the ci-concurrency branch April 13, 2023 12:12
@grst grst mentioned this pull request Apr 13, 2023
Closed
@ivirshup ivirshup mentioned this pull request Apr 13, 2023
Merged
@grst grst mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

@ivirshup ivirshup Awaiting requested review from ivirshup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grst @flying-sheep