Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding model with cycle consistency and VampPrior #2421
base: main
Are you sure you want to change the base?
Adding model with cycle consistency and VampPrior #2421
Changes from 7 commits
a582251
bb359ac
14e41f1
5863b1f
3f49266
6605682
3319fc8
3a67d1c
5edad83
a4b080e
a24ef28
9b05bca
8c25dba
c5f5c37
5b4838c
c885e20
661bbc6
9a49d24
3622eee
e4c1ef9
0f7bd06
9e0cba9
54f5734
df959ed
f65c403
5fcb6f6
3f1cffe
3c93e7f
3e8ffd0
4ce4614
f81abda
bdd2c7a
4507602
cc19d91
c15b8a2
aacdafe
de6db13
235767c
5f04d65
69759ec
2e447c8
9e8cc35
b0829c0
bf2e850
bd5a882
7f50353
01db60a
6cdd3d6
62eb924
b9a9047
b95cb03
9a2a33e
c049ea1
041c6a4
7743c19
1641654
7c3bddc
eb872bc
5015e82
b64b2ba
9b78ba3
2aab4b4
1b50be1
1abf15d
6d32d89
2e59be7
4e0988e
f0eb2b0
3f8be47
776a8e2
ebbe1ca
35e3385
4601808
87a367e
df4b335
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have there been edge case values other than NaNs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike nan_to_num. It's numerically unstable but gives the user no good insight of this issue. Can you describe the type of None errors that you are getting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this class is similar to the existing implementation of
FCLayers
, could you refactorLayers
so that it subclassesFCLayers
and overrides methods as needed? This will make it clearer what's different about this implementation as well as remove duplicate code ininject_into_layer
andset_online_update_hooks
, as it looks like these methods are identical to the originalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inheriting this will make it also easier for us to add new functionality to sysVI. Are there issues with the FClayers class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to avoid nan_to_num
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using softplus activation will be much more stable than exp. Do you need exp here for specific reasons? Clamping v would otherwise be safe (something like 20).