refactor(model): refactor out common minified mode methods#2883
Merged
refactor(model): refactor out common minified mode methods#2883
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
+ Coverage 84.53% 84.60% +0.06%
==========================================
Files 178 178
Lines 15067 15052 -15
==========================================
- Hits 12737 12734 -3
+ Misses 2330 2318 -12
|
canergen
reviewed
Jul 8, 2024
Member
|
@martinkim0 Was this one ready to merge or are things missing? |
canergen
added
cuda tests
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 19, 2024
for more information, see https://pre-commit.ci
…into minified-mode
# Conflicts: # CHANGELOG.md
for more information, see https://pre-commit.ci
meeseeksmachine
pushed a commit
to meeseeksmachine/scvi-tools
that referenced
this pull request
Nov 29, 2024
…ed mode methods
canergen
pushed a commit
that referenced
this pull request
Nov 29, 2024
…on minified mode methods) (#3060) Backport PR #2883: refactor(model): refactor out common minified mode methods Co-authored-by: Martin Kim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.