Skip to content

feat(dataloaders): Custom dataloader registry support #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ori-kron-wis merged 165 commits into from
May 13, 2025

updates with main

67caa96
Select commit
Loading
Failed to load commit list.
Merged

feat(dataloaders): Custom dataloader registry support #2932

updates with main
67caa96
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2025 in 0s

80.16% (target 80.00%)

View this Pull Request on Codecov

80.16% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 81.67614% with 129 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (ced87df) to head (67caa96).

Files with missing lines Patch % Lines
src/scvi/model/base/_base_model.py 49.63% 69 Missing ⚠️
src/scvi/dataloaders/_custom_dataloders.py 91.59% 29 Missing ⚠️
src/scvi/model/base/_archesmixin.py 82.22% 8 Missing ⚠️
src/scvi/model/base/_training_mixin.py 76.47% 8 Missing ⚠️
src/scvi/model/_scanvi.py 86.66% 4 Missing ⚠️
src/scvi/model/base/_rnamixin.py 93.33% 4 Missing ⚠️
src/scvi/model/base/_vaemixin.py 77.77% 4 Missing ⚠️
src/scvi/data/_utils.py 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
+ Coverage   80.12%   80.16%   +0.04%     
==========================================
  Files         196      197       +1     
  Lines       17570    18156     +586     
==========================================
+ Hits        14078    14555     +477     
- Misses       3492     3601     +109
Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/dataloaders/_data_splitting.py 95.47% <ø> (ø)
src/scvi/model/_scvi.py 96.42% <100.00%> (+0.51%) ⬆️
src/scvi/model/base/_save_load.py 83.49% <100.00%> (+1.38%) ⬆️
src/scvi/train/_trainingplans.py 85.73% <100.00%> (+0.41%) ⬆️
src/scvi/data/_utils.py 85.00% <57.14%> (-1.13%) ⬇️
src/scvi/model/_scanvi.py 91.17% <86.66%> (-1.85%) ⬇️
src/scvi/model/base/_rnamixin.py 94.17% <93.33%> (-0.36%) ⬇️
src/scvi/model/base/_vaemixin.py 89.13% <77.77%> (+1.17%) ⬆️
src/scvi/model/base/_archesmixin.py 78.20% <82.22%> (+1.31%) ⬆️
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov