Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mudata support for MultiVI #3038

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: Mudata support for MultiVI #3038

wants to merge 20 commits into from

Conversation

ori-kron-wis
Copy link
Collaborator

Added mudata support for MULTIVI + tests

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Nov 6, 2024
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Nov 6, 2024
@ori-kron-wis ori-kron-wis self-assigned this Nov 6, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (54ba452) to head (b6d2028).

Files with missing lines Patch % Lines
src/scvi/model/_multivi.py 91.30% 2 Missing ⚠️
src/scvi/model/_totalvi.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3038      +/-   ##
==========================================
+ Coverage   84.52%   84.55%   +0.02%     
==========================================
  Files         178      178              
  Lines       15048    15070      +22     
==========================================
+ Hits        12720    12743      +23     
+ Misses       2328     2327       -1
Files with missing lines Coverage Δ
src/scvi/model/_totalvi.py 86.86% <50.00%> (+0.03%) ⬆️
src/scvi/model/_multivi.py 74.57% <91.30%> (+2.31%) ⬆️

@ori-kron-wis ori-kron-wis changed the title (feat) : Mudata support for MultiVI feat: Mudata support for MultiVI Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canergen canergen canergen approved these changes

Assignees

@ori-kron-wis ori-kron-wis

Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
scvi-tools 1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ori-kron-wis @canergen