Skip to content

Backport PR #2932 on branch 1.3.x (feat: Custom dataloader registry support) #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #2932: Custom dataloader registry support

@lumberbot-app lumberbot-app bot added this to the scvi-tools 1.3 milestone May 13, 2025
@lumberbot-app lumberbot-app bot added custom_dataloader PR 2932 on-merge: backport to 1.3.x on-merge: backport to 1.3.x labels May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 81.67614% with 129 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (7236446) to head (202f8b4).
Report is 1 commits behind head on 1.3.x.

Files with missing lines Patch % Lines
src/scvi/model/base/_base_model.py 49.63% 69 Missing ⚠️
src/scvi/dataloaders/_custom_dataloders.py 91.59% 29 Missing ⚠️
src/scvi/model/base/_archesmixin.py 82.22% 8 Missing ⚠️
src/scvi/model/base/_training_mixin.py 76.47% 8 Missing ⚠️
src/scvi/model/_scanvi.py 86.66% 4 Missing ⚠️
src/scvi/model/base/_rnamixin.py 93.33% 4 Missing ⚠️
src/scvi/model/base/_vaemixin.py 77.77% 4 Missing ⚠️
src/scvi/data/_utils.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            1.3.x    #3318      +/-   ##
==========================================
+ Coverage   80.12%   80.16%   +0.04%     
==========================================
  Files         196      197       +1     
  Lines       17570    18156     +586     
==========================================
+ Hits        14078    14555     +477     
- Misses       3492     3601     +109     
Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/dataloaders/_data_splitting.py 95.47% <ø> (ø)
src/scvi/model/_scvi.py 96.42% <100.00%> (+0.51%) ⬆️
src/scvi/model/base/_save_load.py 83.49% <100.00%> (+1.38%) ⬆️
src/scvi/train/_trainingplans.py 85.73% <100.00%> (+0.41%) ⬆️
src/scvi/data/_utils.py 85.00% <57.14%> (-1.13%) ⬇️
src/scvi/model/_scanvi.py 91.17% <86.66%> (-1.85%) ⬇️
src/scvi/model/base/_rnamixin.py 94.17% <93.33%> (-0.36%) ⬇️
src/scvi/model/base/_vaemixin.py 89.13% <77.77%> (+1.17%) ⬆️
src/scvi/model/base/_archesmixin.py 78.20% <82.22%> (+1.31%) ⬆️
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit d80550f into scverse:1.3.x May 13, 2025
16 of 18 checks passed
@ori-kron-wis ori-kron-wis changed the title Backport PR #2932 on branch 1.3.x (Custom dataloader registry support) Backport PR #2932 on branch 1.3.x (feat: Custom dataloader registry support) May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom_dataloader PR 2932 on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants