Skip to content

Feat: Update DestVI V2 model #3380

Merged
ori-kron-wis merged 26 commits intomainfrom
Ori-destvi_v2_2
Nov 26, 2025
Merged

Feat: Update DestVI V2 model #3380
ori-kron-wis merged 26 commits intomainfrom
Ori-destvi_v2_2

Conversation

@ori-kron-wis
Copy link
Collaborator

merge with main branch

@ori-kron-wis ori-kron-wis self-assigned this Jun 9, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label Jun 9, 2025
@ori-kron-wis
Copy link
Collaborator Author

close #1826

@ori-kron-wis ori-kron-wis added on-merge: backport to 1.4.x on-merge: backport to 1.4.x and removed on-merge: backport to 1.3.x on-merge: backport to 1.3.x labels Sep 14, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 75.64356% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.59%. Comparing base (fb38c6d) to head (1fd1b81).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/model/_destvi.py 45.45% 72 Missing ⚠️
src/scvi/module/_mrdeconv.py 86.11% 25 Missing ⚠️
src/scvi/model/_condscvi.py 78.84% 22 Missing ⚠️
src/scvi/module/_vaec.py 95.06% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fb38c6d) and HEAD (1fd1b81). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (fb38c6d) HEAD (1fd1b81)
35 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3380       +/-   ##
===========================================
- Coverage   86.95%   74.59%   -12.36%     
===========================================
  Files         225      225               
  Lines       21273    21593      +320     
===========================================
- Hits        18498    16108     -2390     
- Misses       2775     5485     +2710     
Files with missing lines Coverage Δ
src/scvi/data/_manager.py 96.24% <100.00%> (ø)
src/scvi/model/base/_base_model.py 77.54% <100.00%> (-5.41%) ⬇️
src/scvi/module/_vaec.py 91.24% <95.06%> (+2.08%) ⬆️
src/scvi/model/_condscvi.py 84.10% <78.84%> (-12.57%) ⬇️
src/scvi/module/_mrdeconv.py 85.95% <86.11%> (-9.19%) ⬇️
src/scvi/model/_destvi.py 62.10% <45.45%> (-26.30%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit 39abdb9 into main Nov 26, 2025
20 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Nov 26, 2025
ori-kron-wis added a commit that referenced this pull request Nov 26, 2025
)

Backport PR #3380: Feat: Update DestVI V2 model

Co-authored-by: Ori Kronfeld <ori.kronfeld@weizmann.ac.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants