Skip to content

Stabilize integration tests: fix flaky heartbeat test #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dkropachev wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Stabilize integration tests: fix flaky heartbeat test #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions tests/src/integration/tests/test_heartbeat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ CASSANDRA_INTEGRATION_TEST_F(HeartbeatTests, HeartbeatDisabled) {
*
* @since 2.1.0
* @jira_ticket CPP-152
* @expected_result Heartbeat failure on node 2; node 2 connection is lost.
* @expected_result Heartbeat failure on node 2 is logged.
*/
CASSANDRA_INTEGRATION_TEST_F(HeartbeatTests, HeartbeatFailed) {
CHECK_FAILURE;
Expand All @@ -88,17 +88,16 @@ CASSANDRA_INTEGRATION_TEST_F(HeartbeatTests, HeartbeatFailed) {
default_cluster().with_connection_heartbeat_interval(1).with_connection_idle_timeout(5);
connect(cluster);

cass_uint64_t initial_connections = session_.metrics().stats.total_connections;
std::string paused_node_ip = ccm_->get_ip_prefix() + "2";
Statement statement(SELECT_ALL_SYSTEM_LOCAL_CQL);
statement.set_host(paused_node_ip, 9042);
session_.execute(statement);

pause_node(2);
start_timer();

CassMetrics metrics = session_.metrics();
while (metrics.stats.total_connections >= initial_connections &&
elapsed_time() < 60000) {
session_.execute_async(SELECT_ALL_SYSTEM_LOCAL_CQL); // Simply execute statements ignore any
// error that can occur from paused node
metrics = session_.metrics();
while (logger_.count() == 0 && elapsed_time() < 60000) {
msleep(100);
}
EXPECT_LT(metrics.stats.total_connections, initial_connections);
EXPECT_GE(logger_.count(), 1u);
}